Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPF syscall symbols are confusing #9769

Closed
jackcmay opened this issue Apr 28, 2020 · 5 comments · Fixed by #9804
Closed

BPF syscall symbols are confusing #9769

jackcmay opened this issue Apr 28, 2020 · 5 comments · Fixed by #9804
Assignees
Milestone

Comments

@jackcmay
Copy link
Contributor

Problem

BPF syscall symbols service both Rust and C and different symbols are exported for each language which is not necessary and confusing

Proposed Solution

Consolidate the exported syscall symbols to a single exported symbol where possible.

For example, instead of exporting sol_log and sol_log_ just export `sol_log_' and point all languages to it.

This is a breaking change for existing programs that require all pre-compiled programs to be rebuilt and should go into the first public release that supports programs.

@jackcmay jackcmay self-assigned this Apr 28, 2020
@jackcmay
Copy link
Contributor Author

@mvines 👀

@mvines
Copy link
Member

mvines commented Apr 28, 2020

ok if we're going to do this it needs to go into v1.1, and pretty quickly!

@jackcmay
Copy link
Contributor Author

Yup, how quickly?

@mvines
Copy link
Member

mvines commented Apr 28, 2020

Next week or so doable? Ideally we have some soak time on testnet before promoting to mainnet-beta at the end of May

@jackcmay
Copy link
Contributor Author

Sounds good, I can get it in asap

@mvines mvines added this to the v1.1.8 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants