-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inflation of foundation pool #5786
Comments
@aeyakovenko it's likely we'll have to manually transfer foundation rewards in to the CBC account (they restrict 3rd party deposits) or we keep them in a separate account and combine the two (CBC and foundation rewards) during disassociation. WDYT? |
@aeyakovenko @ericlwilliams any updated thinking on this? |
@rob-solana i think the plan is to handle it of chain. Basically only delegate to people who can follow directions and lockup rewards. |
@aeyakovenko how does that relate to the inflation % specified to the Foundation? |
so the % reward fee that is given to the foundation from the total inflation, is basically like a fixed global commission on all inflation rewards. |
Yeah, that was my understanding as well
…On Wed, Dec 18, 2019 at 8:17 AM anatoly yakovenko ***@***.***> wrote:
@rob-solana <https://github.com/rob-solana> @ericlwilliams
<https://github.com/ericlwilliams>
so the % reward fee that is given to the foundation from the total
inflation, is basically like a fixed global commission on all inflation
rewards.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5786?email_source=notifications&email_token=ABJ4JWPM3LMTHEWDI7LNNPDQZHE65A5CNFSM4ITWJAYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHFDJGI#issuecomment-566899865>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ4JWLLYPZM2XSJGAFOLTLQZHE65ANCNFSM4ITWJAYA>
.
|
The question here is how inflation code will identify the Foundation accounts. Under the current configuration, in the first epoch (~13seconds), the BS leader will be entitled to redeem:
Which is approximately 26SOL. The 2nd epoch is double that, and so on, until other nodes come online and more points are available, which will lead to rewards points dilution. The Foundation is supposed to see 1.5SOL of that first epoch's inflation. |
Does it have to identify the Foundation accounts or can we just specify a
new account where the Foundation inflation rewards land?
…On Sun, Apr 19, 2020 at 5:37 AM Michael Vines ***@***.***> wrote:
Assigned #5786 <#5786> to
@ericlwilliams <https://github.com/ericlwilliams>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#5786 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ4JWPOLQFKFTIRHN34Z2TRNJWXXANCNFSM4ITWJAYA>
.
|
Not sure if this issue is even relevant anymore actually. |
My bad, this is relevant still. The foundation/foundation_term fields in sdk/src/inflation.rs aren't hooked up to anything |
Looks like we're lumping Grant and Foundation inflation issuances into the Foundation terms here, which I think is fine, but since we originally scoped 5% grant & 5% foundation, might bump foundation inflation default to 10% for now. I think 7 years default is also okay to keep for now. Will publish and circulate official numbers before go-live. |
@ericlwilliams @mvines I think we need to address this before enabling inflation on mainnet-beta, which is nearing to realize. :) |
@aeyakovenko what do you think? I think 5% Foundation, 5% grant still sounds reasonable (so w/ 8% initial inflation, that would be 2M tokens for each first year, dropping thereafter). |
@ericlwilliams I need specific hard-coded accounts to transfer the rewards for foundation and grant to like these: solana/core/src/non_circulating_supply.rs Lines 58 to 80 in e556f85
Maybe the accounts will be one of them, because the accounts should be regarded as non-circulating? |
@ryoqun I see! Let me sync with @danpaul000 on this today and try to get those for you |
@ryoqun will the foundation accounts receiving rewards be system accounts, or stake accounts? If system, does it matter if the account exists/is already funded or not? |
It can be any account. The bank would just deposit the foundation rewards in that account. Also consider if we just want 1 account or multiple (and if multiple how do the rewards get split up between them) |
Temporary plan for pico-inflation is to just set the foundation rate to 0% to bypass this entirely |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs. |
Problem
inflation, as specified, is split among validator rewards, storage rewards and the foundation
foundation pool/pools doesn't/don't exist yet
Proposed Solution
possible approaches:
The text was updated successfully, but these errors were encountered: