-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold BIP39 mnemonic-based keypair generation into solana-keygen #5323
Comments
Please consider HD wallet key generation while in the neighborhood: #5246 |
Yep! |
@mvines @garious it feels a bit strange to implement BIP39 without BIP32.. Without BIP32 we decide our own way of deriving keypairs from a mnemonic phrase. For example, in #5889 I derive a keypair secret key from the first 32 bytes of the mnemonic seed. If we support BIP32 later on, we would then have to support two different ways of deriving keypairs. Any recommendations on how to proceed here? |
I'm ok with changing the solana-keygen user interface later when we add BIP32 (cc: #5246) |
Let's bring the functionality of https://github.com/fkbenjamin/solana_keygen into
solana-keygen
:The text was updated successfully, but these errors were encountered: