Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold BIP39 mnemonic-based keypair generation into solana-keygen #5323

Closed
mvines opened this issue Jul 29, 2019 · 5 comments · Fixed by #5889
Closed

Fold BIP39 mnemonic-based keypair generation into solana-keygen #5323

mvines opened this issue Jul 29, 2019 · 5 comments · Fixed by #5889
Assignees
Milestone

Comments

@mvines
Copy link
Member

mvines commented Jul 29, 2019

Let's bring the functionality of https://github.com/fkbenjamin/solana_keygen into solana-keygen:

  1. The ability to output a BIP39 mnemonic for a keypair
  2. The ability to recover a keypair from a BIP39 mnemonic
@mvines mvines added this to the Mavericks v0.18.0 milestone Jul 29, 2019
@garious
Copy link
Contributor

garious commented Jul 29, 2019

Please consider HD wallet key generation while in the neighborhood: #5246

@jstarry
Copy link
Member

jstarry commented Sep 11, 2019

@mvines Doesn't seem like #1 is doable, afaik you cannot recover a mnemonic seed phrase from a generated keypair. What we can do is optionally show a user their mnemonic seed phrase when generating a new keypair. Sound good?

@mvines
Copy link
Member Author

mvines commented Sep 11, 2019

What we can do is optionally show a user their mnemonic seed phrase when generating a new keypair

Yep!

@jstarry
Copy link
Member

jstarry commented Sep 12, 2019

@mvines @garious it feels a bit strange to implement BIP39 without BIP32..

Without BIP32 we decide our own way of deriving keypairs from a mnemonic phrase. For example, in #5889 I derive a keypair secret key from the first 32 bytes of the mnemonic seed. If we support BIP32 later on, we would then have to support two different ways of deriving keypairs.

Any recommendations on how to proceed here?

@mvines
Copy link
Member Author

mvines commented Sep 12, 2019

I'm ok with changing the solana-keygen user interface later when we add BIP32 (cc: #5246)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants