Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend duplicate shred checks for overlapping erasure sets. #33037

Closed
AshwinSekar opened this issue Aug 28, 2023 · 0 comments
Closed

Extend duplicate shred checks for overlapping erasure sets. #33037

AshwinSekar opened this issue Aug 28, 2023 · 0 comments
Assignees
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@AshwinSekar
Copy link
Contributor

Problem

Currently we only detect duplicate coding shreds that are part of the same fec set and have incompatible erasure sets.

Proposed Solution

From behzad:
Any 2 shreds with different but overlapping erasure sets can be considered duplicate.
In particular doesn't even need to have the same fec_set_index.

Technically the overlapping erasure sets might result in non-duplicate shreds, but a leader shouldn't generate overlapping erasure sets unless malicious or buggy.

We should extend the check in blockstore and relax the constraint in gossip to handle proofs for these kind of conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
Development

No branches or pull requests

1 participant