Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and possibly improve accuracy of timestamp oracle #32135

Closed
AshwinSekar opened this issue Jun 14, 2023 · 1 comment
Closed

Investigate and possibly improve accuracy of timestamp oracle #32135

AshwinSekar opened this issue Jun 14, 2023 · 1 comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@AshwinSekar
Copy link
Contributor

AshwinSekar commented Jun 14, 2023

Problem

The timestamp oracle uses timestamps created at vote tx generation, which are then fed into a stake weighted median to estimate the cluster frozen timestamp for a given block. This might not be accurate during volatile situations when consensus lags from replay as well as periods of large vote refreshes.

Proposed Solution

Investigate:

  1. Who uses the timestamp oracle and what are the expected bounds for accuracy?
    Initial proposal says "external auditors or law enforcement".
  2. What exactly are we trying to measure?
    Initial proposal says block produced, however "processed" / "frozen" were also mentioned. Code indicates "voted".
  3. Is the oracle expected to be within the bounds of accuracy for unrooted forks?

Depending on the answers to 1) and 2), it might be more accurate to move the timestamp to the frozen bank time in replay.

If 3) indicates we should be accurate for minor forks as well, then it might be necessary to move the timestamp oracle out of the vote program entirely, as minor forks might only get a few votes, allowing a small amount of stake to skew timestamps on longer minor forks.

@mvines
Copy link
Member

mvines commented Jun 14, 2023

  1. Who uses the timestamp oracle and what are the expected bounds for accuracy?
    Initial proposal says "external auditors or law enforcement".

A resolution of ~24 hours was sufficient for the original consumer of the feature: stake account unlocks. The first external entity that put requirements on this feature too also was ok with a ~24 hour resolution.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

2 participants