Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual (nightly+stable) clippy run is forced under ci due to its bug #31834

Closed
ryoqun opened this issue May 26, 2023 · 2 comments
Closed

Dual (nightly+stable) clippy run is forced under ci due to its bug #31834

ryoqun opened this issue May 26, 2023 · 2 comments
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@ryoqun
Copy link
Member

ryoqun commented May 26, 2023 •
edited
Loading

Problem

temporarily run stable clippy as well to scan the codebase for redundant_clones, which is disabled as nightly clippy is buggy:

rust-lang/rust-clippy#10577

i bisected to a particular upstream pr: rust-lang/rust#108944 (comment)

Proposed Solution

remove the dual run as soon as the upstream fixes this bug and we bump to the fixed nightly toolchain: rust-lang/rust-clippy#10577
@ryoqun ryoqun mentioned this issue May 26, 2023
Merged
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@CriesofCarrots
Copy link
Contributor

@ryoqun , is this still relevant?

@ryoqun ryoqun mentioned this issue Jun 10, 2024
Merged
@ryoqun
Copy link
Member Author

ryoqun commented Jun 10, 2024

@ryoqun , is this still relevant?

yeah. sadly, we have move on: anza-xyz#1661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryoqun @CriesofCarrots