Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: Native program should consume compute units #30620

Closed
tao-stones opened this issue Mar 7, 2023 · 1 comment
Closed

Feature Gate: Native program should consume compute units #30620

tao-stones opened this issue Mar 7, 2023 · 1 comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@tao-stones
Copy link
Contributor

tao-stones commented Mar 7, 2023 •
edited
Loading

Description

Native programs should consume pre-defined compute-units when executed, currently they are not, therefore this change needs to be feature gated to avoid break consensus.

Feature ID

8pgXCMNXC8qyEFypuwpXyRxLXZdpM4Qo72gJ6k87A6wL

Activation Method

Single Core Contributor

Minimum Beta Version

1.16.0

Minimum Stable Version

1.16.0

Testnet Activation Epoch

523

Devnet Activation Epoch

581

Mainnet-Beta Activation Epoch

557
@tao-stones tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Mar 7, 2023
This was referenced Mar 7, 2023
Closed
Closed
Merged
@tao-stones
Copy link
Contributor Author

tao-stones commented Jun 5, 2023 •
edited
Loading

Note: when this feature is activated, compute_unit_limit will be consumed by both builtin and bpf programs. The practical impact to end users is very small since most users set cu_limit with plenty redundancies. But still worth communicate to community. #32080 adjusts cost model/tracking logic accordingly

@tao-stones tao-stones mentioned this issue Jun 12, 2023
Closed
This was referenced Aug 29, 2023
Merged
Merged
This was referenced Jan 8, 2024
Merged
Merged
@Lichtso Lichtso closed this as completed Jan 19, 2024
@tao-stones tao-stones mentioned this issue Mar 3, 2024
Merged
This was referenced Mar 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lichtso @tao-stones