Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ledger-tool snapshot --minimized option may break on ALT updates in slot range #30165

Closed
apfitzge opened this issue Feb 7, 2023 · 3 comments · Fixed by #33273
Closed

ledger-tool snapshot --minimized option may break on ALT updates in slot range #30165

apfitzge opened this issue Feb 7, 2023 · 3 comments · Fixed by #33273

Comments

@apfitzge
Copy link
Contributor

apfitzge commented Feb 7, 2023

Problem

#30158 fixes some AccountLookupTable (ALT) use in the ledger-tool snapshot minimized option. However, it still may break if an ALT is updated in the slot range and a later transaction uses new accounts in the table.

Low-priority right now.

Proposed Solution

Investigate a solution.
@apfitzge
Copy link
Contributor Author

apfitzge commented Feb 7, 2023

CC: @ryoqun

@apfitzge apfitzge mentioned this issue Feb 7, 2023
Merged
@apfitzge
Copy link
Contributor Author

apfitzge commented Feb 7, 2023

See the discussion here for some additional context: https://github.com/solana-labs/solana/pull/30158/files#r1098225396

@apfitzge
Copy link
Contributor Author

I think this is actually easier than I previously had thought.
Previous thought was we'd have to replay the slot range, not sure why I thought that.

We really just need to scan through the txs, as we already are.
Add existing ALTs to our account keep list
Don't add ALTs that are created by a tx in our range.

@apfitzge apfitzge mentioned this issue Sep 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manually add lookup table addresses instead of sanitizing apfitzge/agave
1 participant
@apfitzge