Feature Gate: Validator applies cost tracker to blocks during replay

[tao-stones]

Description

Blocks exceed cost tracker limits (eg. block limit, account limit etc) should fail during replay with proper error.

Feature ID

2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj

Activation Method

Single Core Contributor

Minimum Beta Version

2.0

Minimum Stable Version

No response

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

[tao-stones]

v1.15+ have bunch of changes to cost model, including use requested CU (#27608), add cost to more built-in (#29795), to name a few. This feature should only be activated when cluster is at 1.15+

[tao-stones]

Also IMPORTANT that to enable this feature AFTER QoS adjustment logic is removed, #31379

[apfitzge]

Also IMPORTANT that to enable this feature AFTER QoS adjustment logic is removed, #31379

I think before either of these are activated we need to have some punishing or incentive to request accurate CUs. Otherwise we will kill block size immediately I think?

[tao-stones]

Also IMPORTANT that to enable this feature AFTER QoS adjustment logic is removed, #31379

I think before either of these are activated we need to have some punishing or incentive to request accurate CUs. Otherwise we will kill block size immediately I think?

Yes, #31453 is first step toward to it, hope those actively utilizing priority will first revise their requested CU to be more accurate. If result is positive, can try next steps with SIMD #17

[apfitzge]

https://dune.com/crypto_notte/solana-additional-fee-analysis shows we have roughly 30-60% priority fee usage. I think costs also check for builtins to filter those out, unsure what percentage of txs are just builtins. We probably still have some percentage of non-builtin txs that aren't using priority fees, and would use the default 200k cost. Would be great to get a relative idea on how many non-builtin, non-prioritized txs we actually see, since those are the troublemakers w/ removing the cost adjustment post-execution.

hehe that link for SIMD doesn't work (correct link) - also it's really SIMD 19 😆

[tao-stones]

https://dune.com/crypto_notte/solana-additional-fee-analysis shows we have roughly 30-60% priority fee usage. I think costs also check for builtins to filter those out, unsure what percentage of txs are just builtins. We probably still have some percentage of non-builtin txs that aren't using priority fees, and would use the default 200k cost. Would be great to get a relative idea on how many non-builtin, non-prioritized txs we actually see, since those are the troublemakers w/ removing the cost adjustment post-execution.

#31755 documents fee details by using ledger-tool. Welcome to comment there.

[buffalu]

Blocked on #32285