You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now when adding new fields to snapshot we append them to the end of the snapshot and deserialize them as default on eof. These fields are split between the AccountsDbFieldsToSerialize struct (which happened to originally be serialized at the end of the snapshot) + fields that are manually appended during serialization.
This is quite confusing and it would be better to keep all of these optional fields in a separate struct that is serialized at the end of the snapshot. This will also allow us to easily check the serialization dependency between these fields and avoid any situations where data is being deserialized to the wrong field.
Hopefully this will also make it easier to move these fields properly into the snapshot when we do version upgrades.
Proposed Solution
The text was updated successfully, but these errors were encountered:
Problem
Right now when adding new fields to snapshot we append them to the end of the snapshot and deserialize them as default on eof. These fields are split between the
AccountsDbFieldsToSerialize
struct (which happened to originally be serialized at the end of the snapshot) + fields that are manually appended during serialization.This is quite confusing and it would be better to keep all of these optional fields in a separate struct that is serialized at the end of the snapshot. This will also allow us to easily check the serialization dependency between these fields and avoid any situations where data is being deserialized to the wrong field.
Hopefully this will also make it easier to move these fields properly into the snapshot when we do version upgrades.
Proposed Solution
The text was updated successfully, but these errors were encountered: