Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a struct to organize optional fields that are default_on_eof in snapshot #27202

Closed
AshwinSekar opened this issue Aug 17, 2022 · 1 comment
Assignees
Labels
stale [bot only] Added to stale content; results in auto-close after a week. validator Issues that relate to the validator

Comments

@AshwinSekar
Copy link
Contributor

Problem

Right now when adding new fields to snapshot we append them to the end of the snapshot and deserialize them as default on eof. These fields are split between the AccountsDbFieldsToSerialize struct (which happened to originally be serialized at the end of the snapshot) + fields that are manually appended during serialization.
This is quite confusing and it would be better to keep all of these optional fields in a separate struct that is serialized at the end of the snapshot. This will also allow us to easily check the serialization dependency between these fields and avoid any situations where data is being deserialized to the wrong field.
Hopefully this will also make it easier to move these fields properly into the snapshot when we do version upgrades.

Proposed Solution

@brooksprumo
Copy link
Contributor

Assigned myself as well so that I can find this issue again easily in the future.

@sakridge sakridge added the validator Issues that relate to the validator label Oct 21, 2022
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week. validator Issues that relate to the validator
Projects
None yet
Development

No branches or pull requests

3 participants