Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by quic client and remove #[ignore] annotations #27160

Closed
willhickey opened this issue Aug 15, 2022 · 0 comments
Closed

Fix tests broken by quic client and remove #[ignore] annotations #27160

willhickey opened this issue Aug 15, 2022 · 0 comments
Assignees
Labels
stale [bot only] Added to stale content; results in auto-close after a week. validator Issues that relate to the validator

Comments

@willhickey
Copy link
Contributor

willhickey commented Aug 15, 2022

Problem

These tests are failing as a result of setting DEFAULT_TPU_USE_QUIC = true which enables quic client (see PR #26927).

Notes

Similar failures in other tests caused by port mismatches between client and server (PR #27046) and address mismatches (0.0.0.0 vs 127.0.0.1) ( PR #27071 and #27096)

cargo test --package solana-bench-tps --test bench_tps --all-features -- test_bench_tps_local_cluster_solana --exact --nocapture --include-ignored
Panics with TransportError(Custom("\"ConnectionError(TimedOut)\""))

cargo test --package solana-core --lib --all-features -- banking_stage::tests::test_forwarder_budget --exact --nocapture --include-ignored
Seems to hang. on unaffected branches this test takes a few seconds.

cargo test --package solana-core --lib --all-features -- banking_stage::tests::test_handle_forwarding --exact --nocapture --include-ignored
Seems to hang. on unaffected branches this test takes a few seconds.

cargo test --package solana-dos --bin solana-dos --all-features -- test::test_dos_with_blockhash_and_payer --exact --nocapture --include-ignored
Panics with TransportError(Custom("\"ConnectionError(TimedOut)\""))

cargo test --package solana-dos --bin solana-dos --all-features -- test::test_dos_with_blockhash_and_payer_and_quic --exact --nocapture --include-ignored
Panics with TransportError(Custom("\"ConnectionError(TimedOut)\""))

@willhickey willhickey changed the title Fix test_bench_tps_local_cluster_solana and remove #[ignore] annotation Fix tests broken by quic client and remove #[ignore] annotations Aug 15, 2022
@willhickey willhickey self-assigned this Aug 23, 2022
@sakridge sakridge added the validator Issues that relate to the validator label Oct 21, 2022
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week. validator Issues that relate to the validator
Projects
None yet
Development

No branches or pull requests

2 participants