Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: StakeInstruction::Redelegate #26765

Open
mvines opened this issue Jul 25, 2022 · 5 comments
Open

Feature Gate: StakeInstruction::Redelegate #26765

mvines opened this issue Jul 25, 2022 · 5 comments
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@mvines
Copy link
Member

mvines commented Jul 25, 2022

Description

See #26294

Feature ID

2KKG3C6RBnxQo9jVVrbzsoSh41TDXLK7gBc9gduyxSzW

Activation Method

Single Core Contributor

Deployment Considerations

None

Minimum Beta Version

1.17.0

Minimum Stable Version

1.17.0

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

@mvines mvines added the feature-gate Pull Request adds or modifies a runtime feature gate label Jul 25, 2022
@mvines mvines self-assigned this Jul 28, 2022
@mvines
Copy link
Member Author

mvines commented May 3, 2023

This gate was initially activate on testnet during 361. The current implementation has since been shown to have a flaw that needs to be resolved. When testnet was hard forked for the v1.13/v1.14 downgrade/upgrade trails, this gate was also disabled and it makes sense to keep it disabled until the flaw is resolved.

@mvines
Copy link
Member Author

mvines commented Aug 29, 2023

Fix pending at #32606

@mvines
Copy link
Member Author

mvines commented Aug 29, 2023

@HaoranYi - devnet has this feature activated already without your fixes from #32606. For testnet it's now disabled thanks to the 1.14/1.16 restart though.

I think the right thing to do is to rekey the feature-gate, and backport the rekey only to 1.16 to cause the original feature-gate to turn off on devnet during the next devnet upgrade. There's a slight risk of devnet dying during this upgrade but i think it's probably ok to assume this risk.

@HaoranYi
Copy link
Contributor

yeah. I will create a PR to rekey this feature.

@HaoranYi
Copy link
Contributor

HaoranYi commented Aug 29, 2023

New feature key is GUrp5BKMyDazsAp9mBoVD6orE5ihXNRPC3jkBRfx6Lq7

2KKG3C6RBnxQo9jVVrbzsoSh41TDXLK7gBc9gduyxSzW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

2 participants