Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most builtin programs do not consume compute units #25401

Closed
jstarry opened this issue May 20, 2022 · 2 comments
Closed

Most builtin programs do not consume compute units #25401

jstarry opened this issue May 20, 2022 · 2 comments
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@jstarry
Copy link
Member

jstarry commented May 20, 2022

Problem

BPF programs use a compute meter while processing instructions but builtin native programs don't so they do not consume any compute units for processing instructions.

Proposed Solution

Consume a reasonable amount of compute units for each builtin program instruction

tag @jackcmay @taozhu-chicago

@tao-stones
Copy link
Contributor

cost_model counts native program costs separately from BPF programs. It gives static CUs to some native programs, defined at here.

If native programs will consume similar CUs, then cost_model can be simplified as it no longer need to distinguish native programs from BPF.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
@tao-stones
Copy link
Contributor

#30702 has made all builtin to consume static CUs. This issue should be considered as addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

3 participants
@jstarry @tao-stones and others