Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track computation units used per account during replay #25166

Closed
jdavis103 opened this issue May 12, 2022 · 0 comments
Closed

Track computation units used per account during replay #25166

jdavis103 opened this issue May 12, 2022 · 0 comments
Assignees
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@jdavis103
Copy link
Contributor

jdavis103 commented May 12, 2022

Problem

A new system is in place to detect blocks that have gone over the max total allowed number of computation units, during Replay, terminating processing in that case. However, it is also possible for a single account to go above the writable-account computation unit limit for a block, without the block as a whole going over the total limit.

Proposed Solution

Detect this case, likely leveraging the CostTracker code already being used for this purpose by the Leader, and terminate processing the same as in the too-much-total-computation case. This can (and likely should) include not just writable-account limits, but all the different types of tracking that CostTracker handles, including account data size limits, etc.

@jdavis103 jdavis103 self-assigned this May 12, 2022
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 15, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

1 participant