Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: Prevent calling precompiles as programs #24746

Closed
jstarry opened this issue Apr 27, 2022 · 3 comments · Fixed by #27100
Closed

Feature Gate: Prevent calling precompiles as programs #24746

jstarry opened this issue Apr 27, 2022 · 3 comments · Fixed by #27100
Assignees
@jackcmay
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@jstarry
Copy link
Member

jstarry commented Apr 27, 2022 •
edited
Loading

Description

Should not be able to call a precompiled program directly because they are validated before instruction processing.

Feature ID

4ApgRX3ud6p7LNMJmsuaAcZY5HWctGPr5obAsjB3A54d

Activation Method

Single Core Contributor

Testnet Activation Epoch

277

Devnet Activation Epoch

297

Mainnet-Beta Activation Epoch

332
@jstarry jstarry added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 27, 2022
@jstarry
Copy link
Member Author

jstarry commented Apr 27, 2022

Before enabling this feature on mainnet-beta, we need to be sure that this fix #24743 is running on warehouse / rpc nodes to ensure that tx metadata is correct.

@jstarry jstarry mentioned this issue Apr 27, 2022
Closed
@jstarry
Copy link
Member Author

jstarry commented May 4, 2022 •
edited
Loading

If this is activated before #24743 is fixed and the record_instruction_in_transaction_context_push feature is activated, it will break the functionality of the get_processed_sibling_instruction syscall as described here: #24705 (comment)

cc #24964

@jstarry
Copy link
Member Author

jstarry commented May 5, 2022

To be clear, this feature cannot be activated on mainnet until record_instruction_in_transaction_context_push (#24965) is activated

@jstarry jstarry mentioned this issue Aug 12, 2022
Merged
@mergify mergify bot closed this as completed in #27100 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackcmay jackcmay

Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean feature: prevent_calling_precompiles_as_programs jstarry/solana
2 participants
@jstarry @jackcmay