Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: Automatically rewind stake credits when vote-account credits are zeroes #24674

Closed
CriesofCarrots opened this issue Apr 26, 2022 · 4 comments · Fixed by #32211
Closed
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Milestone

Comments

@CriesofCarrots
Copy link
Contributor

CriesofCarrots commented Apr 26, 2022

Description

Currently this bug means that stake-account credits observed on a vote account that has been destroyed and recreated are wrong.

This feature gate will sync (reset) such a stake account's observed credits on the epoch boundary following the vote-account credit-wiping.

Feature ID

BUS12ciZ5gCoFafUHWW8qaFMMtwFQGVxjsDheWLdqBE2

Activation Method

Single Core Contributor

Minimum Beta Version

v1.11.0

Minimum Stable Version

v1.11.0

Testnet Activation Epoch

355

Devnet Activation Epoch

432

Mainnet-Beta Activation Epoch

464

@CriesofCarrots CriesofCarrots added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 26, 2022
@CriesofCarrots CriesofCarrots self-assigned this May 6, 2022
@CriesofCarrots CriesofCarrots modified the milestones: v1.12.0, v1.11.0 May 13, 2022
@refi93
Copy link

refi93 commented Feb 21, 2023

@CriesofCarrots any ETA on this feature being activated on mainnet-beta?

@mvines
Copy link
Member

mvines commented Feb 21, 2023

Per https://github.com/solana-labs/solana/wiki/Feature-Gate-Activation-Schedule#current-schedule, it's the fourth feature that will be activated once mainnet upgrades to 1.14.

@refi93
Copy link

refi93 commented Feb 21, 2023

Thanks! If I understand correctly, after the feature being activated, no action from the affected node's operators (like re-creating the vote account) is needed for the affected delegations to start earning rewards again, right?

@mvines
Copy link
Member

mvines commented Feb 21, 2023

correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants