Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected response from RPC API getSignaturesForAddress when until sig not found #24620

Closed
jstarry opened this issue Apr 23, 2022 · 5 comments
Closed
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@jstarry
Copy link
Member

jstarry commented Apr 23, 2022

Problem

When an RPC node receives a getSignaturesForAddress request and cannot find the signature used in the until parameter, it will just return a list of the most recent signatures (up to the limit). This is unexpected in cases where a signature has been confirmed by the cluster but the contacted RPC node has not yet confirmed the signature yet because it is slightly behind. See issue here: #24417

Proposed Solution

If until cannot be found, return an error response

@jstarry
Copy link
Member Author

jstarry commented Apr 23, 2022

@CriesofCarrots what do you think about the proposed solution here?

@CriesofCarrots
Copy link
Contributor

I think we may want different handling depending on whether a provided before signature is found or not -- I want to think through that a little more. But in the case of no before and not-found until, yes, I think an error response makes a lot of sense.

@ghost
Copy link

ghost commented Aug 3, 2022

This is still an issue, any updates on this? thanks

@arturferreira

This comment was marked as duplicate.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
@jstarry jstarry reopened this Oct 6, 2023
@jstarry jstarry removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 6, 2023
@CriesofCarrots
Copy link
Contributor

The proposed fix isn't completely trivial to implement, since we support before/until signatures that don't involve the specified address, and since we check both Blockstore and Bigtable for results. I'd be happy to look a PR for this, though, @jstarry

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

3 participants