Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped block hashes shouldn't be stored in the recent blockhashes queue #24387

Closed
jstarry opened this issue Apr 15, 2022 · 0 comments · Fixed by #24389
Closed

Skipped block hashes shouldn't be stored in the recent blockhashes queue #24387

jstarry opened this issue Apr 15, 2022 · 0 comments · Fixed by #24389
Assignees

Comments

@jstarry
Copy link
Member

jstarry commented Apr 15, 2022

Problem

As demonstrated in #24242, the recent blockhashes queue tracks hashes for skipped blocks. The recent blockhash queue should only be storing hashes for produced blocks.

Proposed Solution

Use a feature gate to stop adding skipped block hashes the recent blockhash queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant