Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: updates rewards at epoch boundary using cached accounts #24278

Closed
behzadnouri opened this issue Apr 12, 2022 · 0 comments
Closed
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@behzadnouri
Copy link
Contributor

behzadnouri commented Apr 12, 2022

Description

When rewards are calculated at the epoch boundary, stake and vote account are loaded from accounts-db, which is slow.
#24200 will instead use cache stake and vote accounts in Bank.stakes.

These cached accounts are synchronized with accounts-db after each transaction, and so there should not be any change in the resulting computation:
https://github.com/solana-labs/solana/blob/d2702201c/runtime/src/bank.rs#L4526
Nevertheless, to avoid any chances of introducing a consensus issue, the switch to cached account is feature gated.

Feature ID

28s7i3htzhahXQKqmS2ExzbEoUypg9krwvtK2M9UWXh9

Activation Method

Single Core Contributor

Testnet Activation Epoch

470

Devnet Activation Epoch

506

Mainnet-Beta Activation Epoch

477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

1 participant