Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Come up with a better name for accounts_data_len #23759

Closed
Tracked by #21604
brooksprumo opened this issue Mar 18, 2022 · 1 comment
Closed
Tracked by #21604

Come up with a better name for accounts_data_len #23759

brooksprumo opened this issue Mar 18, 2022 · 1 comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@brooksprumo
Copy link
Contributor

lgtm, beyond that accounts_data_len name that I still think is a little misleading.

total_accounts_size?

Originally posted by @mvines in #23714 (review)

Bank::accounts_data_len tracks the total on-chain size of the accounts data. What is a better name to communicate that description?

  • total or no?
  • account or accounts?
  • data or no?
  • len or size?

This name (and some variants) also live in:

  • AccountsDataMeter
  • CostTracker
  • banking stage
  • replay stage
  • instruction errors
  • transaction errors

If the Bank field is renamed, should all these others get renamed as well?
This was referenced Mar 18, 2022
Merged
Closed
@t-nelson
Copy link
Contributor

global_accounts_data_bytes? cumulative_accounts_data_bytes?

🚲 🛖

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Mar 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t-nelson @brooksprumo