Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify & combine "with" and "without" incremental snapshots code paths in bootstrap #20848

Closed
brooksprumo opened this issue Oct 21, 2021 · 0 comments · Fixed by #25732
Closed

Simplify & combine "with" and "without" incremental snapshots code paths in bootstrap #20848

brooksprumo opened this issue Oct 21, 2021 · 0 comments · Fixed by #25732
Assignees
@brooksprumo

Comments

@brooksprumo
Copy link
Contributor

brooksprumo commented Oct 21, 2021 •
edited
Loading

Problem

During bootstrap, we either take a "with incremental snapshots" path or a "without incremental snapshots path". This (1) has a bunch of code duplication, and (2) prevents auto-fallback from "with" to "without"

Proposed Solution

Combine the two paths. "with" should be tried first (assuming --no-incremental-snapshot-fetch is not set). If no snapshots are found, fall back to "without"

More context on Discord

Related to #17088, #19885, and PR #20696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine bootstrap mods: with and without incremental snapshots diman-io/solana
1 participant
@brooksprumo