Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash mismatch 1.4 vs. 1.5 w/JIT #15175

Closed
sakridge opened this issue Feb 6, 2021 · 7 comments
Closed

Hash mismatch 1.4 vs. 1.5 w/JIT #15175

sakridge opened this issue Feb 6, 2021 · 7 comments
Assignees
Milestone

Comments

@sakridge
Copy link
Member

sakridge commented Feb 6, 2021

Problem

Devnet experienced a hash mismatch which looks like a divergence with interpreted vs. JIT paths.

Continued from this:
#14948 (comment)
#14948 (comment)

Proposed Solution

Debug and fix.

@sakridge
Copy link
Member Author

Fixed by solana-labs/rbpf#140

@mvines mvines modified the milestones: v1.5.8, v1.5.9 Feb 17, 2021
@jackcmay
Copy link
Contributor

@sakridge Are you aware of any further action on this issue?

@sakridge
Copy link
Member Author

@sakridge Are you aware of any further action on this issue?

I was trying to decide what to do with it.. nobody read my message and moved the JIT part to here. We can close this and re-open #14948

@jackcmay
Copy link
Contributor

@sakridge afaik rbpf #140 fixes the hash mismatch in #14948. Can you elaborate on what the outstanding issue is?

@sakridge
Copy link
Member Author

@sakridge afaik rbpf #140 fixes the hash mismatch in #14948. Can you elaborate on what the outstanding issue is?

#14948 was originally for the mismatch that was found in the KIN simulation run. JIT was not enabled in that context and only votes and SPL programs are being executed there, so it wasn't the JIT-related issue. The JIT issue was an instance of mismatch on devnet, and while they were both hash mismatches, they are not the same issue. That's why I tried to move the JIT issue debug into a new issue (this one).

@jackcmay
Copy link
Contributor

Ah, so let's close this issue with rbpf #140.

As for #14948, that issue's conversation went to the jit/devnet. You want to re-establish a new direction there?

@sakridge
Copy link
Member Author

Ah, so let's close this issue with rbpf #140.

As for #14948, that issue's conversation went to the jit/devnet. You want to re-establish a new direction there?

Or maybe just open an entirely new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants