-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an section for SPL Token integration to the exchange integration guide #12281
Comments
Seems like we're going to want to add an |
What would this do over |
Display the mint |
Ok, so like eg, some of my tokens:
|
Right. User want's to withdraw their |
I suppose we'll also need to plumb the offline flags |
Ah, I see. We could just add the token mint to |
I think we can do this later, on demand. These aren't widely used 🙈 |
We could easily add a RpcClient::getTokenAccount method that queries |
This feels like the more flexible way to go to me. It'd replace the |
The rpc plumbing is already there. It would just be a different client method for spl-token to call: |
Yep, perfect! |
FYI, this issue could perhaps be repurposed to cover the new RPC call |
Considerations:
spl-token
program is distributed as a source crate only. We might need to add binary release artifacts, perhaps include spl-token in the standard Solana release artifacts?spl-token create-account
). This requires a pinch of Sol per user for rent, and is not quite as convenient as the native token deposit workflow. The user will need to "register their intent" in the Exchange UI. There may be other alternatives such as using the SPL Token delegate facility (but sollet.io doesn't do delegates yet), "memo field" for transfers into a common exchange SPL Token deposit address, etc.solana transfer --no-wait
to avoid blocking their withdrawal pipeline.spl-token transfer
may be fast enough since it only waits for single confirmation, but if not then we'll need a--no-wait
option here as well.Some
freeze authority, an external party has the power to freeze tokens under their custody. This is something they need to be aware ofThe text was updated successfully, but these errors were encountered: