Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taper of inflation is based on epoch 0, not the inflation activation epoch #11130

Closed
ryoqun opened this issue Jul 20, 2020 · 5 comments
Closed
Milestone

Comments

@ryoqun
Copy link
Member

ryoqun commented Jul 20, 2020

Problem

taper of inflation is calculated as if the inflation was enabled since the very start of our cluster (genesis, epoch 0/slot 0). But it isn't true.

So, although initial interest rate is expected to be 15% at the start of inflation, it actually will be about ~14.28% without proper offsetting implementation:

const DEFAULT_INITIAL: f64 = 0.15;
const DEFAULT_TERMINAL: f64 = 0.015;
const DEFAULT_TAPER: f64 = 0.15;

As far as I understand the token economy correctly, I think the planned initial inflation rate should be aligned with the time when the inflation is enabled, not the time of birth of our cluster.

Proposed Solution

Make it possible to take consider of inflation activation epoch?

CC: @ericlwilliams @mvines @rwalker-com

@ryoqun
Copy link
Member Author

ryoqun commented Jul 20, 2020

slightly related to this (w.r.t. inflation parameters): #5786 #10093

@rwalker-com
Copy link
Contributor

assuming the network enables inflation soon, I think the fudge would probably be fine

another approach could be to increase inflation.initial so that it's actually 0.15 at inflation X

@ericlwilliams
Copy link
Contributor

ericlwilliams commented Jul 20, 2020

Yeah, I think Rob's suggestion would be fine (adjusting inflation.initial so that the inflation rate is what we want it to be when it turns on.
Keep in mind, 15% is just a placeholder and not likely the actual target (which will probably be around 6-9%). Depends on what the staking distribution looks like closer to inflation launch

@ryoqun
Copy link
Member Author

ryoqun commented Jul 22, 2020

@rwalker-com @ericlwilliams I see. Thanks for checking this! Then this issue will be just simple constant changing PR. :)

@mvines mvines added this to the v1.4.0 milestone Aug 18, 2020
@mvines
Copy link
Member

mvines commented Sep 25, 2020

I think there's no explicit action needed here. As we finalize on the inflation rate we'll just adjust the initial values to match the desired % when inflation is activated

@mvines mvines closed this as completed Sep 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants