Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3: Enable eager rent collect across gapped epochs on mainnet-beta #10810

Closed
ryoqun opened this issue Jun 25, 2020 · 3 comments · Fixed by #12842
Closed

v1.3: Enable eager rent collect across gapped epochs on mainnet-beta #10810

ryoqun opened this issue Jun 25, 2020 · 3 comments · Fixed by #12842
Assignees
@ryoqun
Milestone
v1.3.19

Comments

@ryoqun
Copy link
Member

ryoqun commented Jun 25, 2020 •
edited
Loading

Problem

this needs to be updated for mainnet-beta:

solana/runtime/src/bank.rs

Lines 1871 to 1873 in 50f7ed8

OperatingMode::Stable => {
#[cfg(not(test))]
let should_enable = current_epoch >= Epoch::max_value();

Context

#10206
@ryoqun ryoqun mentioned this issue Aug 3, 2020
Merged
@ryoqun ryoqun changed the title v1.3: Enable earger rent collect across gapped epochs on mainnet-beta v1.2: Enable earger rent collect across gapped epochs on mainnet-beta Aug 11, 2020
@ryoqun
Copy link
Member Author

ryoqun commented Aug 11, 2020

Enable this after #10809 is applied on the testnet and some time passed.

@mvines mvines added this to the v1.2.22 milestone Aug 15, 2020
@mvines mvines assigned t-nelson and unassigned mvines Aug 15, 2020
@mvines mvines modified the milestones: v1.2.22, v1.3.4 Aug 15, 2020
@joncinque joncinque modified the milestones: v1.3.4, v1.3.6 Aug 28, 2020
@oJshua oJshua modified the milestones: v1.3.8, v1.3.9 Sep 3, 2020
@mvines mvines modified the milestones: v1.3.9, v1.3.10 Sep 9, 2020
@ryoqun ryoqun modified the milestones: v1.3.10, v1.2.29, v1.3.11 Sep 15, 2020
@mvines mvines changed the title v1.2: Enable earger rent collect across gapped epochs on mainnet-beta v1.2: Enable eager rent collect across gapped epochs on mainnet-beta Sep 15, 2020
@mvines mvines changed the title v1.2: Enable eager rent collect across gapped epochs on mainnet-beta v1.3: Enable eager rent collect across gapped epochs on mainnet-beta Sep 15, 2020
@ryoqun ryoqun modified the milestones: v1.3.11, v1.3.12 Sep 15, 2020
@mvines mvines modified the milestones: v1.3.12, v1.3.13 Sep 20, 2020
@mvines mvines modified the milestones: v1.3.14, v1.3.16 Oct 3, 2020
@mvines mvines modified the milestones: v1.3.16, v1.3.17, v1.3.18 Oct 11, 2020
@mvines mvines assigned ryoqun and unassigned t-nelson Oct 13, 2020
@mvines
Copy link
Member

mvines commented Oct 13, 2020

@ryoqun - can you please port this feature activation to FeatureSet then roll it out to mainnet-beta over the next v1.3 release or two

This was referenced Oct 13, 2020
Merged
Merged
@ryoqun
Copy link
Member Author

ryoqun commented Oct 13, 2020

@ryoqun - can you please port this feature activation to FeatureSet then roll it out to mainnet-beta over the next v1.3 release or two

@mvines roger! finally this is getting some care: #12842

@CriesofCarrots CriesofCarrots modified the milestones: v1.3.18, v1.3.19 Oct 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryoqun ryoqun

Labels
None yet
Projects
None yet
Milestone
v1.3.19
Development

Successfully merging a pull request may close this issue.

Port various rent fixes to runtime feature ryoqun/solana
6 participants
@ryoqun @oJshua @t-nelson @joncinque @mvines @CriesofCarrots