Invalid tick count causes slot dumping

[sakridge]

Problem

Validators can dump their slots if they encounter an invalid tick count slot, but this error was expected and dumping/redownloading the slot is just wasted effort.

Proposed Solution

Detect this case and don't dump, or at least detect if there is some other different version of the slot available.

[brianlong]

Whenever I see this error in my logs, the current slot is spoiled along with the three following slots. In this sequence, the leader made the 1st block, messed-up the 2nd block, and didn't submit the 3rd or 4th.

{"leader":"BSF2yD9mqzaixDaLEraF1en82EWaXx7wbaCqSuKppqG5","skipped":false,"slot":30817244},
{"leader":"BSF2yD9mqzaixDaLEraF1en82EWaXx7wbaCqSuKppqG5","skipped":true,"slot":30817245},
{"leader":"BSF2yD9mqzaixDaLEraF1en82EWaXx7wbaCqSuKppqG5","skipped":true,"slot":30817246},
{"leader":"BSF2yD9mqzaixDaLEraF1en82EWaXx7wbaCqSuKppqG5","skipped":true,"slot":30817247}

(30817246 & 30817247 do not appear in my logs)

The next leader in line skipped 30817248 and then submitted blocks in the next 3 slots.

{"leader":"Db2V7nPHc4sPHne87nYXPGn8Kv8rMsiWCAjgAXmpqcpC","skipped":true,"slot":30817248},
{"leader":"Db2V7nPHc4sPHne87nYXPGn8Kv8rMsiWCAjgAXmpqcpC","skipped":false,"slot":30817249},
{"leader":"Db2V7nPHc4sPHne87nYXPGn8Kv8rMsiWCAjgAXmpqcpC","skipped":false,"slot":30817250},
{"leader":"Db2V7nPHc4sPHne87nYXPGn8Kv8rMsiWCAjgAXmpqcpC","skipped":false,"slot":30817251}

[brianlong]

@sakridge Is the problem that I highlighted above directly related to this particular Issue #? If not, I will create a new Issue to track it.

[brianlong]

I think I will create a new Issue # since they seem like different issues.

[sakridge]

@brianlong I think this is a different issue. I think this is not an issue in the current code because the slot dumping is disabled at the moment.