Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete Error Handling in sendEncodedTransaction #3561

Open
paur94 opened this issue Nov 13, 2024 · 1 comment
Open

Incomplete Error Handling in sendEncodedTransaction #3561

paur94 opened this issue Nov 13, 2024 · 1 comment
Labels
invalid This doesn't seem right

Comments

@paur94
Copy link

paur94 commented Nov 13, 2024

The sendEncodedTransaction function’s error handling is incomplete, missing essential fields like name, error code. This omission prevents the isSolanaError check from working as intended, limiting error traceability and debugging.
@paur94 paur94 added the bug Something isn't working label Nov 13, 2024
@steveluscher
Copy link
Collaborator

Can you go into more detail here? isSolanaError() is from the v2.x line, and sendEncodedTransaction() is from the v1.x line, so those are not designed to work together.

What are you trying to do, what's happening, and what did you expect to happen?

@steveluscher steveluscher added invalid This doesn't seem right and removed bug Something isn't working labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveluscher @paur94