Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transfer-hook] Remove deprecated functions from cli #6307

Closed
samkim-crypto opened this issue Feb 28, 2024 · 4 comments
Closed

[transfer-hook] Remove deprecated functions from cli #6307

samkim-crypto opened this issue Feb 28, 2024 · 4 comments

Comments

@samkim-crypto
Copy link
Contributor

Problem

Solana clap-v3 utils deprecated a number of functions with version 1.18. #6278 temporarily suppresses the warnings from deprecated functions.

Solution

Remove the deprecated functions from the cli.
@samkim-crypto samkim-crypto mentioned this issue Feb 28, 2024
Merged
@tonton-sol
Copy link
Contributor

tonton-sol commented Feb 28, 2024 •
edited
Loading

Working on this but the crate solana-clap-v3-utils has not been updated with your latest changes. IE 'SignerSource' is private and there is no 'pubkey_from_source' function in crate. Not sure if this issue is on my end.

@samkim-crypto
Copy link
Contributor Author

I apologize for this 🙏 . The PR that exposes SignerSource and adds pubkey_from_source has been backported and merged to 1.18 (solana-labs/solana#34678). These will be available in the next 1.18 release. Thanks for pointing this out!

@tonton-sol
Copy link
Contributor

Thank you! I am glad I'm not crazy 🤪

@tonton-sol tonton-sol mentioned this issue Mar 31, 2024
Merged
@joncinque
Copy link
Contributor

Resolved with #6525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joncinque @samkim-crypto @tonton-sol