Add optional ed25519_init() #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use some code comments |
|
Anything in particular you feel should be commented in this patch? In general I totally agree, this entire file is devoid of comments so where to start!? |
|
Justification of any sort for the change |
|
Sure, I added some description to the commit message: f81494d |
This function permits ed25519_verify_many() users to ensure the GPU is initialized correctly and if not take action rather than having the failure suppressed. ed25519_verify_many() retains its previous behavior of implicit initialization if ed25519_init() is not explicitly called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for solana-labs/solana#626 to land