Refactor - Assign SBPF versions to SIMDs #602
Open
+343
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
from
88e0c85
to
b6d8898
Compare
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
from
b6d8898
to
4b2c3df
Compare
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
3 times, most recently
from
dcf9245
to
785454e
Compare
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
from
6f0ba50
to
08bcb37
Compare
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
from
08bcb37
to
60a4eed
Compare
Lichtso
force-pushed
the
refactor/assign_sbpf_versions_to_simds
branch
from
60a4eed
to
dbd0844
Compare
LucasSte
reviewed
Nov 22, 2024
| @@ -402,7 +402,7 @@ impl Verifier for RequisiteVerifier { | |||
| ebpf::CALL_REG => { check_callx_register(&insn, insn_ptr, sbpf_version)?; }, | |||
| ebpf::EXIT if !sbpf_version.static_syscalls() => {}, | |||
| ebpf::RETURN if sbpf_version.static_syscalls() => {}, | |||
| ebpf::SYSCALL if sbpf_version.static_syscalls() => { | |||
| ebpf::SYSCALL if sbpf_version.stricter_controlflow() => { | |||
There was a problem hiding this comment.
This one is still static syscall isn't it?
| @@ -2068,7 +2070,7 @@ mod test { | |||
| assert!(matches!( | |||
| ElfExecutable::parse_ro_sections( | |||
| &config, | |||
| &SBPFVersion::V1, // v2 requires optimize_rodata=true | |||
| &SBPFVersion::V0, // v2 requires optimize_rodata=true | |||
| - `add64 reg, imm` can use `r11` as destination register | ||
|
|
||
| ### until v3 | ||
| - The targets of `call` instructions (which includes `syscall` instructions) is checked at runtime not verification time |
There was a problem hiding this comment.
Suggested change
| - The targets of `call` instructions (which includes `syscall` instructions) is checked at runtime not verification time | |
| - The targets of `call` instructions (which includes `syscall` instructions) are checked at runtime not verification time |
|
|
||
| ### until v3 | ||
| - The targets of `call` instructions (which includes `syscall` instructions) is checked at runtime not verification time | ||
| - The offset of jump instructions must be limited to the range of the bytecode |
There was a problem hiding this comment.
Should this be the range of the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.