Add verify command to verified build tab #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deriving the PDA from the upgrade authority and the program id, then getting the parameter from the PDA and composing it into a solana-verify comand
|
@Woody4618 is attempting to deploy a commit to the Solana Labs Team on Vercel. A member of the Team first needs to authorize it. |
ngundotra
reviewed
Oct 25, 2024
ngundotra
requested changes
Oct 25, 2024
ngundotra
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I think this is mostly good to go. I am approving to unblock.
Last q - do you think we should explain the security aspect "verified" builds at the top of this card? I think most people will assume it's like audited - without really understanding it's just a plausible way for developers to link their code to their program.
ngundotra
force-pushed
the
add-verify-command-from-pda
branch
from
ec113e8
to
de66cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like this people can easily copy the command from the explorer and verify for themselfs.
Related Issue:
#393
Looks like this:
And like this when there is no Verify PDA:
