Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deeper subdirectory for github #444

Open
Ailrun opened this issue May 21, 2021 · 1 comment · May be fixed by #445
Open

Support deeper subdirectory for github #444

Ailrun opened this issue May 21, 2021 · 1 comment · May be fixed by #445

Comments

@Ailrun
Copy link

Ailrun commented May 21, 2021

I have a project using depth-2 subdirectories for packages (like util/validate), and this causes hpack a parse error like the following:

<project path>/util/validate/package.yaml: Error while parsing $.github - expected owner/repo or owner/repo/subdir, but encountered "<owner>/<repo>/util/validate"

Is it possible to support this?

@dpwiz
Copy link

dpwiz commented Jun 16, 2021

The patch is simple, but conflicts with the resolution of #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants