Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an exclude or blacklis class of modules #440

Open
andrewufrank opened this issue Mar 13, 2021 · 2 comments
Open

add an exclude or blacklis class of modules #440

andrewufrank opened this issue Mar 13, 2021 · 2 comments

Comments

@andrewufrank
Copy link

The automatism for computing the list of modules to include is nice and works most of the time, but there are numerous cases where a source file in a source directory should not be included (i.e. excluded or blacklisted). There were several questions to this effect in the issue tracker and there is a standard workaround (which each new user has to find..). The workaround is neither obvious nor without its own problems.
I suggest that you add a keyword blacklist which accepts a list or a dictionary of module names not to include in the modules list (neither the exposed nor the other-modules list).

I think this is a conservative extension which could not break any existing code (the workaround will still work) and I do not see any interactions with other parts of hpack (but I admit that I have not considered every mechanism).

Thank you for hpack - it makes writing and managing haskell code much more productive!

@tfausak
Copy link
Collaborator

tfausak commented Mar 13, 2021

Are you talking about this? #303 (comment)

If so, the workaround is mentioned prominently in the README as of #404: https://github.com/sol/hpack/blob/f1aa0c48eb696d66be8c1bcf68528253eab09178/README.md#handling-of-paths_-modules

That being said, it might be nice to have it as a first class feature.

@andrewufrank
Copy link
Author

I use the workaround mentioned in #404 - but felt a cleaner solution would be desirable.
Thank you for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants