Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent attribute names for Base::Ph1::Switch and Base::Ph3::Switch #314

Open
MarvinTollnitschRWTH opened this issue Jul 6, 2024 · 0 comments
Open

Inconsistent attribute names for Base::Ph1::Switch and Base::Ph3::Switch #314

MarvinTollnitschRWTH opened this issue Jul 6, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MarvinTollnitschRWTH
Copy link
Contributor

The attribute (const CPS::Attribute::Ptr) storing the state of the switch (open, closed) has different names in the base switch classes:

Base::Ph1::Switch: mIsClosed
Base::Ph3::Switch: mSwitchClosed

This could be unified so only one of the names is used in all switches.
@leonardocarreras leonardocarreras added enhancement New feature or request help wanted Extra attention is needed labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leonardocarreras @MarvinTollnitschRWTH