Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Flow does not work for Dockerfile changes #301

Open
n-eiling opened this issue Jun 7, 2024 · 3 comments
Open

CI Flow does not work for Dockerfile changes #301

n-eiling opened this issue Jun 7, 2024 · 3 comments
Labels
ci enhancement New feature or request

Comments

@n-eiling
Copy link
Contributor

n-eiling commented Jun 7, 2024

Because the CI does not build the dev container but instead uses one that has to be build manually, we cannot properly check changes to the Dockerfile.

I feel like the switch to the github actions really was a regression in many ways. With the gitlab runner we used to build the containers for each PR separately and were still faster than github.

Has anyone somehow tested changes to the dockerfiles without just pushing a new image to the registry and hoping for the best?

@georgii-tishenin
Copy link
Collaborator

Hi, @n-eiling, I am pretty new to this topic and have not yet made any changes to the dockerfiles. Do you already have some ideas to improve on testing the changes of the Dockerfile? E.g., can the dev container build be automated?

@n-eiling
Copy link
Contributor Author

n-eiling commented Jun 7, 2024

yes, but afaik it was removed because it took too long. The only solution I see is moving to self hosted runners.
Or define a workflow for Dockerfile changes that avoids this.

@m-mirz
Copy link
Contributor

m-mirz commented Jun 8, 2024

As @n-eiling mentioned, we already had this automated but building the container images in the ci takes forever since we only use free resources in GitHub. So currently, the docker build job is triggered manually in the actions menu.

@leonardocarreras leonardocarreras added enhancement New feature or request ci labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants