Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier : show involved file when failure #189

Open
jibidus opened this issue Oct 7, 2020 · 5 comments
Open

prettier : show involved file when failure #189

jibidus opened this issue Oct 7, 2020 · 5 comments
Labels
chore Side task

Comments

@jibidus
Copy link
Contributor

jibidus commented Oct 7, 2020

In case of prettier check failure, it is hard to find out what is the problem (which rule is involved) and where is the problem (which file, which line). So it takes some time to find how to fix the issue, whereas it may be avoided easily:

  • display which file is not valid + which rule is violated

More over, the task yarn prettier:format (which can be used to resolve the violation, or not) does not follow the prettier semantic for the same purpose : write. So, this may be time consuming for new dev which already know prettier (very widely used) and is easy to fix:

  • rename task prettier:format to prettier:write.
@jibidus jibidus added the chore Side task label Oct 7, 2020
@JulioJu
Copy link
Contributor

JulioJu commented Oct 8, 2020

I don't understand what is the problem.

@jibidus
Copy link
Contributor Author

jibidus commented Oct 8, 2020

Je modifié la description pour j'espère être plus clair.

@JulioJu
Copy link
Contributor

JulioJu commented Oct 8, 2020

Ah ok, cool, je comprends mieux :-) . Merci :-) .

@jibidus
Copy link
Contributor Author

jibidus commented Oct 8, 2020

@JulioJu
Copy link
Contributor

JulioJu commented Oct 8, 2020

question

Je me mélange dans les PR (c'est ça de bosser pour ma boîte et de checker mes notifs GitHub en même temps)

J'ai viré mon commentaire hors sujet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Side task
Projects
None yet
Development

No branches or pull requests

2 participants