Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autosetup in prep section needs p1 flag added. #114

Open
fuzzball81 opened this issue Mar 28, 2017 · 2 comments
Open

autosetup in prep section needs p1 flag added. #114

fuzzball81 opened this issue Mar 28, 2017 · 2 comments

Comments

@fuzzball81
Copy link
Contributor

If a spec file contains autosetup in the prep section, the -p1 flag needs to be appended to allow git formatted patches to be applied.

@yazug
Copy link
Contributor

yazug commented Mar 28, 2017

if using rdopkg patch to add patches and the following modification is required to make patches apply

-%autosetup -n %{pypi_name}-%{upstream_version}
+%autosetup -n %{pypi_name}-%{upstream_version} -p1

if -S git is present -p1 is not needed

@yac
Copy link
Contributor

yac commented Mar 28, 2017

There are currently sanity checks that fail rdopkg patch/new-version on certain .spec errors, see
specfile.sanity_check.

So adding sanity_check_autosetup there would be simplest way to prevent this error without touching the .spec too much.

In order for automated fixing of stuff, some work on a streamlined and reausable solution is needed as described in #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants