Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew installation #1167

Closed
maciektr opened this issue Mar 4, 2024 · 6 comments
Closed

Fix homebrew installation #1167

maciektr opened this issue Mar 4, 2024 · 6 comments
Assignees

Comments

@maciektr
Copy link
Contributor

maciektr commented Mar 4, 2024

Original report: github.com/cairo-book/cairo-book/issues/647

Repro:

> brew install scarb

> scarb cairo-run
error: no such command: `cairo-run`

> scarb commands 
Installed Commands:
add          : Add dependencies to a Scarb.toml manifest file
build         : Compile current project
cache         : Manipulate packages cache
check         : Analyze the current package and report errors, but don't build Sierra files
clean         : Remove generated artifacts
commands       : List installed commands
fetch         : Fetch dependencies of packages from the network
fmt          : Format project files
init         : Create a new Scarb package in existing directory
manifest-path     : Print path to current Scarb.toml file to standard output
metadata       : Output the resolved dependencies of a package, the concrete used versions including overrides, in machine-readable format
new          : Create a new Scarb package at <PATH>
package        : Assemble the local package into a distributable tarball
publish        : Upload a package to the registry
remove        : Remove dependencies from a manifest file
run          : Run arbitrary package scripts
test         : Execute all unit and integration tests of a local package
update        : Update dependencies

>  ls /opt/homebrew/Cellar/scarb/2.5.4/bin
scarb
@maciektr maciektr self-assigned this Mar 4, 2024
@maciektr maciektr changed the title Fixed homebrew installation Fix homebrew installation Mar 4, 2024
@chenrui333
Copy link

not sure if I should comment in here, but I am actually seeing some build issue with 2.6.0 release

Homebrew/homebrew-core#165078

  error[E0432]: unresolved import `serde_json::value::RawValue`
     --> scarb/src/compiler/plugin/proc_macro/compilation.rs:11:5
      |
  11  | use serde_json::value::RawValue;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `RawValue` in `value`
      |

@maciektr
Copy link
Contributor Author

maciektr commented Mar 5, 2024

I see it has been added in [email protected]. Do you know which version are you using? In Cargo.lock we have

[[package]]
name = "serde_json"
version = "1.0.114"

So should compile ok unless it does not use the lock for some reason? 🤔

@chenrui333
Copy link

@maciektr
Copy link
Contributor Author

maciektr commented Mar 5, 2024

Oh, interesting! Thanks for the log, I'll submit a fix.

@chenrui333
Copy link

checking on the new release now.

@chenrui333
Copy link

the new release build works fine for me in my local, checking with ci now, Homebrew/homebrew-core#165078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants