-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Architecture 0.76.1 fails to build after react native screens got installed #2475
Comments
@mikey18 Hello! Could you provide us with information what kind of error do you get? Any kind of stacktrace and logging message is precious. I've tested the fresh app with react-native-screens and it seems to work like charm |
rn.error.mp4This is the error i get C:\Users\mike\Documents\Bare RN test project\Lendsqr>npm run android
info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor FAILURE: Build failed with an exception.
C++ build system [configure] failed while executing: CMake Error at C:/Users/mike/Documents/Bare RN test project/Lendsqr/node_modules/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake:89 (target_link_libraries): C++ build system [configure] failed while executing: CMake Error at C:/Users/mike/Documents/Bare RN test project/Lendsqr/node_modules/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake:89 (target_link_libraries):
BUILD FAILED in 1m 15s |
this line:
in the very beginning of the stack trace indicates a mismatch in CMake version used for build. @mikey18 Please take a look here for indication what version I'm working with: #2442 (comment) I don't think this is react-native-screens issue. It looks to me like this is react native cli who fails to properly link the library (add it as subdirectory to the main project). Later stack traces are just results of the library being not properly linked. One thing that still bothers me is this change: #2432 Do you have capacity to apply it manually in node_modules / use a patch and checkout whether it helps? I'm not sure what kind of error it prevents, but it might be it. |
Hey, I applied the patch, it did not work, I still get the same error, I tried using the version you worked with in #2442 (comment) but it does not support the latest react-navigtion/native-stack this is the error: C:\Users\mike\Documents\Bare RN test project\Lendsqr>npm install [email protected] You asked if I had the capacity to apply it manually in node_modules, I am not confident about that, but I will give It my best shot, meanwhile I am still open to other solutions. |
@mikey18 I was talking about CMake version, not react-native-screens. You should use latest screens (3.35.0) and try playing around with CMake version. I've just noticed, that I've not uploaded the picture of my Android SDK manager to the comment I've linked - fixed this.
Ok, then it's on react native cli I guess. You should open an issue there & link our discussion. I'll close the issue, because we don't have clear reproduction & all information points to the react native cli or mismatched CMake version. I'm not limiting the conversation though. Feel free to tag me & ask. I'll try to help as much as I can here. |
You can try the following:
|
Okay @kkafar i will try out the CMake version you used and give my feedback |
@kkafar I attempted to implement the CMake versions you recommended, but unfortunately, the issue persists. While the suggested modifications appeared promising, the build process still fails to complete successfully. |
I realized I saved one of my folder names with white spaces, I removed them, and it works now, my bad for saving my folder with white spaces. Thanks for your effort, I really appreciate a lot. |
Glad to hear you got it working |
Can you be more specific with this? I think I might have the same problem |
i cannot get it worked. only work if i not enable new architecture react-native-native 0.74.2 |
Description
I am building my app with bare React Native. I installed very few libraries, and it builds without any issues. After that, I wanted to start integrating React Navigation into my app. However, as soon as I install react-native-screens, clear the cache, and try to build the app, it crashes.
Steps to reproduce
Snack or a link to a repository
https://github.com/mikey18/lendsqr-fp-news
Screens version
3.35.0
React Native version
0.76.1
Platforms
Android
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Fabric (New Architecture)
Build type
Debug mode
Device
Android emulator
Device model
Pixel 3a API 29 (Android 10.0 Q)
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: