Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TR SYSTEM LANGUAGE PROBLEM #1849

Closed
mehmettasan opened this issue Jul 29, 2023 · 8 comments
Closed

TR SYSTEM LANGUAGE PROBLEM #1849

mehmettasan opened this issue Jul 29, 2023 · 8 comments
Labels
Missing repro This issue need minimum repro scenario Platform: Android This issue is specific to Android Platform: Windows This issue is specific to Windows

Comments

@mehmettasan
Copy link

Description

After installing the React Navigaton package, I get an error when I try to install this package while the system language is Turkish. When I change the system language to English, it installs without any problems. I am using windows 11 and the operating system is up to date.
this screenshot is for react-native-safe-area-context but same problem exists in this package.
Ekran görüntüsü_20230728_183744

Steps to reproduce

1- change system language turkish
2- npm install @react-navigation/native
3- npm install react-native-screens react-native-safe-area-context
4- npx react-native run-android

Snack or a link to a repository

none

Screens version

3.23.0

React Native version

0.72.3

Platforms

Android, Windows

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Platform: Windows This issue is specific to Windows Missing repro This issue need minimum repro scenario labels Jul 29, 2023
@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@mehmettasan
Copy link
Author

i trying with clean project. if you want see this problem you can change your windows language turkish and just run project.

@mehmettasan
Copy link
Author

i can share a repo but if you using any language you cant get a error.

@kkafar
Copy link
Member

kkafar commented Jul 29, 2023

Hey @mehmettasan,

looking at the screenshot you provided, my first impression is that the problem might be related to character encoding used by your language (notice that every I letter is replaced with some weird symbol)? To my best knowledge Turkish uses some diacritic signs that might not be encoded with ASCII (maybe even UTF-8) and different encoding could be problematic for compilers to handle? That is just my first guess and I must disclaim that my expertise is very limited in that matter 😅 However I'm not aware of anything special in any of those libs you mentioned (especially react-native-screens) that could lead to such problems.

Is this problem of yours specific only to these libs? What happens if you try to build application that do not use them? Does the project compile then?

@mehmettasan
Copy link
Author

Hey @mehmettasan,

looking at the screenshot you provided, my first impression is that the problem might be related to character encoding used by your language (notice that every I letter is replaced with some weird symbol)? To my best knowledge Turkish uses some diacritic signs that might not be encoded with ASCII (maybe even UTF-8) and different encoding could be problematic for compilers to handle? That is just my first guess and I must disclaim that my expertise is very limited in that matter 😅 However I'm not aware of anything special in any of those libs you mentioned (especially react-native-screens) that could lead to such problems.

Is this problem of yours specific only to these libs? What happens if you try to build application that do not use them? Does the project compile then?

no, that's not the problem. It gets resolved when I change the kotlin version or change the system language to english. but when I install the package directly in Turkish language, it gives an error.

@kkafar
Copy link
Member

kkafar commented Jul 29, 2023

Can you elaborate on what does installing package directly in Turkish mean?

Do you change kotlin version of whole application or only "affected" libraries?

To what version of Kotlin do you change?
If changing Kotlin version works for you it indicates that indeed compiler has some troubles with handling special characters / encoding.

Can you confirm for me, that building application without these libraries (react-navigation, react-native-screens, react-native-safe-area-context) works?

@mehmettasan
Copy link
Author

Can you elaborate on what does installing package directly in Turkish mean?

Do you change kotlin version of whole application or only "affected" libraries?

To what version of Kotlin do you change? If changing Kotlin version works for you it indicates that indeed compiler has some troubles with handling special characters / encoding.

Can you confirm for me, that building application without these libraries (react-navigation, react-native-screens, react-native-safe-area-context) works?

th3rdwave/react-native-safe-area-context#421

its my other issue for safe area context. i trying with clean project and just installing react navigation and this packages. i change kotlin version 1.9.0. you can look my other issue for more. some turkish people have this problem too.

@kkafar
Copy link
Member

kkafar commented Aug 21, 2023

Hey, as this issue seems to be stale and all information I've managed to gather nudges me towards conclusion that this is rather a Kotlin compiler problem (as bumping it resolves the problem) I'll close the issue.

I recommend setting custom kotlin version for now, however it is likely that in close future we will bump kotlinVersion used by this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: Android This issue is specific to Android Platform: Windows This issue is specific to Windows
Projects
None yet
Development

No branches or pull requests

2 participants