Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web LA] Start exiting after position fix #6308

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jul 22, 2024

Summary

While preparing presentation about web LA I've found out that exiting animation has strange order of operations - first animation is started and then position of the element is adjusted (by scroll and other factors). In theory, this may lead to flickers so I believe it will be better to start animation after we adjust position.

Test plan

Tested on example app

@m-bert m-bert requested a review from piaskowyk July 22, 2024 13:05
@m-bert m-bert added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 976a4b8 Jul 22, 2024
7 checks passed
@m-bert m-bert deleted the @mbert/start-exiting-after-position-change branch July 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants