Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library not compatible with React Native 0.73 #5346

Closed
ravindraguptacapgemini opened this issue Nov 7, 2023 · 3 comments
Closed

Library not compatible with React Native 0.73 #5346

ravindraguptacapgemini opened this issue Nov 7, 2023 · 3 comments
Labels
Needs review Issue is ready to be reviewed by a maintainer Platform: Android This issue is specific to Android Repro provided A reproduction with a snippet of code, snack or repo is provided

Comments

@ravindraguptacapgemini
Copy link

ravindraguptacapgemini commented Nov 7, 2023

Description

I am trying the latest RC version of React Native, I see few issues to work with Reanimated library:

  1. Android build.gradle is not updated to include namespace definition.
  2. On build I am getting below error:
    /node_modules/react-native-reanimated/android/src/reactNativeVersionPatch/messageQueueThread/latest/com/swmansion/reanimated/ReanimatedMessageQueueThread.java:7: error: ReanimatedMessageQueueThread is not abstract and does not override abstract method isIdle() in MessageQueueThread
    public class ReanimatedMessageQueueThread extends ReanimatedMessageQueueThreadBase {
    ^
    Note: Some input files use or override a deprecated API.
    Note: Recompile with -Xlint:deprecation for details.
    Note: Some input files use unchecked or unsafe operations.
    Note: Recompile with -Xlint:unchecked for details.
    1 error

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':react-native-reanimated:compileDebugJavaWithJavac'.

Compilation failed; see the compiler error output for details.

Steps to reproduce

Integrate Reanimated with latest RC of React Native (0.73.0-rc.3)

  1. Lots of error related to C++20 extension

Snack or a link to a repository

https://snack.expo.io/

Reanimated version

3.5.4

React Native version

0.73.0-rc.3

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@ravindraguptacapgemini ravindraguptacapgemini added the Needs review Issue is ready to be reviewed by a maintainer label Nov 7, 2023
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: Android This issue is specific to Android label Nov 7, 2023
@tjzel
Copy link
Collaborator

tjzel commented Nov 7, 2023

Hi @ravindraguptacapgemini. If you want to test Reanimated with RC version of React-Native you should try our latest nightly build, since e.g. we recently merged support for React Native 0.73. cc @piaskowyk if any of the mentioned errors here sounds familiar to you.

@tjzel tjzel added Repro provided A reproduction with a snippet of code, snack or repo is provided and removed Missing repro This issue need minimum repro scenario labels Nov 7, 2023
@Latropos
Copy link
Contributor

Latropos commented Nov 7, 2023

Yes, Reanimated 3.4 still doesn't support React Native 0.73, please see the compatibility table: https://docs.swmansion.com/react-native-reanimated/docs/guides/compatibility

@Latropos Latropos closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs review Issue is ready to be reviewed by a maintainer Platform: Android This issue is specific to Android Repro provided A reproduction with a snippet of code, snack or repo is provided
Projects
None yet
Development

No branches or pull requests

3 participants