Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading files to existing release resets its properties #108

Closed
filips123 opened this issue Jun 9, 2021 · 1 comment · Fixed by #109
Closed

Uploading files to existing release resets its properties #108

filips123 opened this issue Jun 9, 2021 · 1 comment · Fixed by #109

Comments

@filips123
Copy link
Contributor

I have a workflow that runs on a new pushed tag that is created when I create a release from GitHub website. I want that workflow builds some things and then attaches the files to the existing release for that tag that I created.

This works and the files are uploaded correctly to the release without it being overwritten. However, this also resets release's name to tag and clears its pre-release status (and all other properties, excluding description). This is caused by https://github.com/softprops/action-gh-release/blob/master/src/github.ts#L182-L186 which sets all properties to data provided in workflow config.

I think the solution to this could be to only use data from workflow config when they are explicitly provided (or when a completely new release is created) and otherwise retain them from the existing release.

@henryiii
Copy link

Same problem. This has been wiping all my release titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants