Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production builds still try to live reload #438

Closed
oliverzheng opened this issue Feb 15, 2023 · 2 comments
Closed

Production builds still try to live reload #438

oliverzheng opened this issue Feb 15, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@oliverzheng
Copy link

Describe the bug
In the developer console, I can see socket.io network requests being sent for a production build. E.g. on https://book-book-mailing.vercel.app/

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://book-book-mailing.vercel.app/previews/Reservation/reservationWithError
  2. Open dev console
  3. See network requests for pulling.

Weirdly, only some of the demos on the Mailing website experience this.

Expected behavior
No live reload happens on production build.

Screenshots
image

Desktop (please complete the following information):

  • OS: Mac OS X 13.1
  • Browser: Chrome
  • Version: 109.0.5414.119

Additional context

@psugihara
Copy link
Collaborator

Good catch. Let's remove that by checking if NODE_ENV === "production"

@psugihara psugihara added bug Something isn't working good first issue Good for newcomers labels Feb 28, 2023
@marcincodes
Copy link
Collaborator

@psugihara This issue can be closed. Fix was merged here: #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants