Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a Subscriber to integrate with skywalking #96

Closed
leizhiyuan opened this issue May 7, 2018 · 4 comments
Closed

Provide a Subscriber to integrate with skywalking #96

leizhiyuan opened this issue May 7, 2018 · 4 comments
Labels
enhancement New feature or request extension Integrate with 3rd component
Milestone
5.4.3

Comments

@leizhiyuan
Copy link
Contributor

leizhiyuan commented May 7, 2018 •
edited
Loading

Expected behavior

Provide a Subscriber to integrate with skywalking, and use a processr to process ,which will be enhanced by skywalking

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • SOFARPC version:
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:

#33
@khotyn
Copy link
Member

khotyn commented May 7, 2018

Is this duplicated with #33 ?

@leizhiyuan
Copy link
Contributor Author

this issue is some discuss for sofa rpc

we also need dev skywalking plugin in skywalking project, I will update there.

@leizhiyuan
Copy link
Contributor Author

maybe we can use these filters to integrate with skywalking, It is more light and covers many protocols.
com.alipay.sofa.rpc.filter.ConsumerInvoker
com.alipay.sofa.rpc.filter.ProviderInvoker

@ujjboy ujjboy added enhancement New feature or request extension Integrate with 3rd component labels May 10, 2018
@leizhiyuan
Copy link
Contributor Author

已经支持,在 skywalking 的5.0的版本中会有.

https://github.com/apache/incubator-skywalking/blob/master/docs/Supported-list.md

SOFARPC 5.4.0

@leizhiyuan leizhiyuan added this to the 5.4.3 milestone Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request extension Integrate with 3rd component
Projects
None yet
Milestone
5.4.3
Development

No branches or pull requests
3 participants
@khotyn @ujjboy @leizhiyuan