Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

sofaboot-dependencies should only have lookout starters and lookout registry extensions #2

Open
khotyn opened this issue Oct 12, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@khotyn
Copy link
Member

khotyn commented Oct 12, 2018

Current sofaboot-dependencies have a lot of lookout dependencies, such as lookout-common, lookout-api and etc.

When user want to change the lookout version, he can't just change the the lookout starter version but also have to add all the lookout dependencies.

Otherwise, will result in the following situation, for example:

Change the project's lookout version to a snapshot version:

<dependencies>
    <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-web</artifactId>
    </dependency>
    <dependency>
        <groupId>com.alipay.sofa.lookout</groupId>
        <artifactId>lookout-sofa-boot-starter</artifactId>
        <version>1.5.2-SNAPSHOT</version>
    </dependency>
    <dependency>
        <groupId>com.alipay.sofa.lookout</groupId>
        <artifactId>lookout-reg-prometheus</artifactId>
        <version>1.5.2-SNAPSHOT</version>
    </dependency>

    <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-test</artifactId>
        <scope>test</scope>
    </dependency>
</dependencies>

The dependencies of the project will be:

image

which could cause NoSuchMethodError or other problem.

@khotyn khotyn added the enhancement New feature or request label Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant