Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86_64-linux-gnu-gcc: error: csgraph_mod/shortest_path_mod.c: No such file or directory #1

Closed
gonzaparra opened this issue Aug 2, 2017 · 6 comments

Comments

@gonzaparra
Copy link
Collaborator

The following file is missing /csgraph_mod/shortest_path_mod.c

I added it to the folder and I was able to install the package correctly.

@galicae
Copy link
Collaborator

galicae commented Aug 17, 2017

can you give me more info? When I tried a fresh install this did not happen. I fixed a couple of other things that prevented an installation, but never had this particular error message. The .c file is generated from the .pyx during setup, hence why we don't ship it.

@gonzaparra
Copy link
Collaborator Author

image

@galicae
Copy link
Collaborator

galicae commented Aug 17, 2017

turns out that in order to compile cython code you need to have installed cython 🤔 who would have thought... Updated the README in order to reflect this, might look into how to install dependencies automatically in a later release.

@galicae galicae closed this as completed Aug 17, 2017
@croth1
Copy link

croth1 commented Aug 17, 2017

Niko, the idea is to submit the auto generated *.c files to the repository. The setup.py uses cython if it is present - if not it tries to fall back to the *.c files.

@galicae
Copy link
Collaborator

galicae commented Aug 18, 2017

isn't the idea though that the c files are going to reflect the architecture of the OS? Also, cython isn't a monstrous dependency to have. This has been discussed elsewhere. There is no recommended best practice, the best I could find was (as always) this SO comment (where you probably stole the cython setup.py from anyway). I would be grateful for suggestions!

@galicae galicae reopened this Aug 18, 2017
@croth1
Copy link

croth1 commented Aug 18, 2017

well the setup.py I stole borrowed uses cython as an optional dependency and expects the c files in the repository. It's easy to adapt the setup.py to make cython a mandatory dependency. I have no strong opinions what the best way is.

@galicae galicae closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants