Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starto migration status not updating fix and Backend listing as SSP fix #1360

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

josephjacobmorris
Copy link
Contributor

@josephjacobmorris josephjacobmorris commented Nov 26, 2022

What type of PR is this?
/kind bug fix

What this PR does / why we need it:

  1. In Strato functional testing yesterday discovered that after creating migration plans. Even though object is migrated from src to the target bucket the status of the migration plan doesn't reflect the same due to an internal issue in code related to the database update

  2. In Storage Service Plan mode of installation backends was getting listed as SSPs

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:
/kind TESTED

Test Report:

Storage Service Plan Testing

Creating a service plan now lists the service plan instead of the previous backends
image

Creating bucket with SSP is now working
image

Migration from one cloud vendor to another

  • Migration from AWS to GCP
    Status and number of objects migrated is correct
    image
    Object is also present in the target bucket
    image

  • Migration from GCP to AWS
    Status and number of objects migrated is correct
    image
    Object is aslo present in the target bucket
    image

Special notes for your reviewer:

go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #1360 (0659f05) into master (de94184) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59           

@josephjacobmorris josephjacobmorris changed the title [WIP] Starto migration from one cloud vendor to another fix [WIP] Starto migration status not updating fix and Backend listing as SSP fix Nov 26, 2022
@josephjacobmorris josephjacobmorris changed the title [WIP] Starto migration status not updating fix and Backend listing as SSP fix Starto migration status not updating fix and Backend listing as SSP fix Nov 26, 2022
@josephjacobmorris josephjacobmorris requested review from PravinRanjan10 and removed request for joseph-v November 26, 2022 06:39
@PravinRanjan10 PravinRanjan10 requested review from joseph-v, kumarashit and rajat-soda and removed request for PravinRanjan10 November 26, 2022 06:39
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PravinRanjan10 PravinRanjan10 merged commit 2ccac52 into sodafoundation:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants