-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
500 Internal Error for GET, PUT, DELETE Backend for a non existing backend #932 #1343
Conversation
0e97118
to
c43ee38
Compare
@kumarashit please review |
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
=======================================
Coverage 48.12% 48.12%
=======================================
Files 10 10
Lines 1571 1571
=======================================
Hits 756 756
Misses 756 756
Partials 59 59 |
@vineela1999 @rajat-soda plz review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This will modify response of the GET Backend API with invalid ID, DELETE Backend API with invalid ID and UPDATE Backend API with invalid ID.
Now the response is 500. The modified response will be 404 with proper error message.
Error MSG : Invalid backend id:
Which issue(s) this PR fixes:
Fixes #932
Test Report Added?:
/kind TESTED
Test Report:
Get Invalid Backend
DELETE invalid backend
GET valid backend
DELETE valid backend
Create valid backend
Special notes for your reviewer: