Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 Internal Error for GET, PUT, DELETE Backend for a non existing backend #932 #1343

Merged
merged 1 commit into from
May 1, 2022

Conversation

amitdn2005
Copy link
Contributor

@amitdn2005 amitdn2005 commented Apr 28, 2022

#932

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature

/kind bug fix

/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
This will modify response of the GET Backend API with invalid ID, DELETE Backend API with invalid ID and UPDATE Backend API with invalid ID.
Now the response is 500. The modified response will be 404 with proper error message.

Error MSG : Invalid backend id:

Which issue(s) this PR fixes:

Fixes #932

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind TESTED

/kind NOT-TESTED

Test Report:

Get Invalid Backend

image

DELETE invalid backend

image

GET valid backend

image

DELETE valid backend

image

Create valid backend

image

Special notes for your reviewer:

@amitdn2005 amitdn2005 changed the title [WIP] 500 Internal Error for GET, PUT, DELETE Backend for a non existing ba… 500 Internal Error for GET, PUT, DELETE Backend for a non existing ba…ckend #932 Apr 29, 2022
@amitdn2005 amitdn2005 changed the title 500 Internal Error for GET, PUT, DELETE Backend for a non existing ba…ckend #932 500 Internal Error for GET, PUT, DELETE Backend for a non existing backend #932 Apr 29, 2022
@amitdn2005 amitdn2005 force-pushed the fix-932 branch 2 times, most recently from 0e97118 to c43ee38 Compare April 29, 2022 14:31
@PravinRanjan10
Copy link
Collaborator

@kumarashit please review

@PravinRanjan10
Copy link
Collaborator

LGTM

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #1343 (6ba4be9) into master (4285082) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59           

@PravinRanjan10
Copy link
Collaborator

@vineela1999 @rajat-soda plz review

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PravinRanjan10 PravinRanjan10 self-requested a review May 1, 2022 01:54
Copy link
Collaborator

@PravinRanjan10 PravinRanjan10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PravinRanjan10 PravinRanjan10 merged commit cf16fe6 into sodafoundation:master May 1, 2022
@PravinRanjan10 PravinRanjan10 added SODACODE2022 SODACODE2022 Hackathon Label SODAMED SODACODE2022 Hackathon Medium Priority Label labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODAMED SODACODE2022 Hackathon Medium Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 Internal Error for GET, PUT, DELETE Backend for a non existing backend
3 participants