Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soda2Consumer should not require username and password, specify token should be enough #23

Open
bowenli86 opened this issue Feb 13, 2017 · 4 comments
Assignees

Comments

@bowenli86
Copy link

Why Soda2Consumer require username and password? Shouldn't providing token is enough? If I interact with the server via http, token is the only thing I need

@chrismetcalf
Copy link
Contributor

You can use the constructor that just takes a base URL:

public static final Soda2Consumer newConsumer(final String url)

Would that work for you instead?

@chrismetcalf chrismetcalf self-assigned this Feb 13, 2017
@bowenli86
Copy link
Author

Not really. According to section 'Throttling and Application Tokens' in https://dev.socrata.com/consumers/getting-started.html, if developers don't specify a token, there'll be throttling of app's requests.

@bowenli86
Copy link
Author

Are you ok if I submit a PR to add another constructor, which only requires url and token, to Soda2Consumer?

@chrismetcalf
Copy link
Contributor

@bowenli86 Sorry for not following up sooner, but of course a pull request would be welcome.

FYI, within the next day or two I'll be merging #27, which should dramatically clean up running the tests and such, and will introduced TravisCI testing to our workflow as well. Long overdue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants